sql: add final projection during physical plan's finalization #50973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
force-pushed
the
finalize-plan
branch
3 times, most recently
from
c105ab5 to
836b50b
Compare
RaduBerinde
approved these changes
Jul 5, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
pkg/sql/distsql_physical_planner.go, line 3394 at r1 (raw file):
// Add a final projection so that DistSQLReceiver gets the rows of the // desired schema. Note that we don't need to update PlanToStreamColMap // since it is no longer necessary.
[nit] maybe set PlanToStreamColMap to nil just in case
yuzefovich
force-pushed
the
finalize-plan
branch
2 times, most recently
from
05dbb26 to
476380a
Compare
yuzefovich
requested review from
a team and
pbardea
and removed request for
a team
This commit updates the contract between `DistSQLReceiver` and `FinalizePlan` method so that the latter adds a projection which allows the DistSQL receiver to get the rows with the desired schema. This shouldn't have any effect on the performance, but it seems like a cleaner approach. Release note: None
yuzefovich
commented
Jul 6, 2020
There was a problem hiding this comment.
I had to make several changes to fix a few things, so I'd appreciate another quick look before merging this.
Reviewable status:
pkg/sql/distsql_physical_planner.go, line 3394 at r1 (raw file):
Previously, RaduBerinde wrote…
[nit] maybe set
PlanToStreamColMaptoniljust in case
Done.
RaduBerinde
reviewed
Jul 6, 2020
There was a problem hiding this comment.
Reviewable status:
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the contract between
DistSQLReceiverandFinalizePlanmethod so that the latter adds a projection which allowsthe DistSQL receiver to get the rows with the desired schema. This
shouldn't have any effect on the performance, but it seems like a
cleaner approach.
Release note: None