util/mon: don't crash when shrinking by too much #50962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
asubiotto
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
nit in the commit message and PR title: s/not/don't
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
Previously, we called `panic` when `Shrink`ing the memory account by too much. Such scenario indicates that our memory accounting is off, but we shouldn't be crashing - we should report an error instead, and this commit does that. Release note (bug fix): Previously, CockroachDB could crash when internal memory accounting hit a discrepancy. Now it will report an error instead.
yuzefovich
changed the title
|
TFTR! bors r+ |
|
bors r+ |
Build succeeded |
This was referenced Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we called
panicwhenShrinking the memory account bytoo much. Such scenario indicates that our memory accounting is off,
but we shouldn't be crashing - we should report an error instead, and
this commit does that.
Fixes: #50804.
Release note (bug fix): Previously, CockroachDB could crash when
internal memory accounting hit a discrepancy. Now it will report an
error instead.