Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: change GEOS symlink to a copy #50881

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

otan
Copy link
Contributor

@otan otan commented Jul 1, 2020

Instead of symlinking to the correct GEOS directory, force a copy
following the symlinks instead. This dramatically simplifies release
scripts from needing to follow symlinks to add the file to the
archive/Docker container.

Release note: None

@otan otan requested review from petermattis and a team July 1, 2020 14:50
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @petermattis)

@otan otan force-pushed the makefile_to_cp branch 2 times, most recently from bd63d5d to 7ae9a15 Compare July 1, 2020 16:41
Instead of symlinking to the correct GEOS directory, force a copy
following the symlinks instead. This dramatically simplifies release
scripts from needing to follow symlinks to add the file to the
archive/Docker container.

Release note: None
@otan otan force-pushed the makefile_to_cp branch from 7ae9a15 to 40f919a Compare July 1, 2020 16:50
@otan
Copy link
Contributor Author

otan commented Jul 1, 2020

bors r=petermattis

@craig
Copy link
Contributor

craig bot commented Jul 1, 2020

Build succeeded

@craig craig bot merged commit 54c7f57 into cockroachdb:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants