geogfn: apply bounding box calculations for DWithin #50825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
force-pushed
the
bounding_box_geogfn_d
branch
from
d4c2ff4 to
ea4b673
Compare
sumeerbhola
requested changes
Jun 30, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @otan)
pkg/geo/geogfn/dwithin.go, line 35 at r1 (raw file):
} distanceToExpand := s1.Angle(distance / spheroid.SphereRadius)
how about s/distanceToExpand/angleToExpand/
otan
force-pushed
the
bounding_box_geogfn_d
branch
from
ea4b673 to
5907d3c
Compare
otan
commented
Jun 30, 2020
There was a problem hiding this comment.
Reviewable status:
pkg/geo/geogfn/dwithin.go, line 35 at r1 (raw file):
Previously, sumeerbhola wrote…
how about s/distanceToExpand/angleToExpand/
Done.
sumeerbhola
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
otan
force-pushed
the
bounding_box_geogfn_d
branch
from
5907d3c to
5987119
Compare
Expand a BoundingRect by a given radius (using s2.Cap) and apply intersection to do fairly cheap bounding box calculations before doing the expensive DWithin logic. Release note: None
otan
force-pushed
the
bounding_box_geogfn_d
branch
from
5987119 to
51ddf02
Compare
|
bors r=sumeerbhola |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand a BoundingRect by a given radius (using s2.Cap) and apply
intersection to do fairly cheap bounding box calculations before doing
the expensive DWithin logic.
Release note: None