Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geopb: rename Shape to ShapeType #50658

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

otan
Copy link
Contributor

@otan otan commented Jun 25, 2020

Rename Shape to ShapeType, in preparation for a new Shape protobuf.

Release note: None

Rename Shape to ShapeType, in preparation for a new Shape protobuf.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan requested review from sumeerbhola and a team June 25, 2020 19:40
Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 20 of 20 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@otan
Copy link
Contributor Author

otan commented Jun 29, 2020

bors r=sumeerbhola

@craig
Copy link
Contributor

craig bot commented Jun 29, 2020

Build succeeded

@craig craig bot merged commit 74d7021 into cockroachdb:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants