Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-19.2: server: Apply cookie auth to /debug/ endponts #50489

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

bdarnell
Copy link
Contributor

Backport 1/1 commits from #50483.

/cc @cockroachdb/release


These legacy endpoints were previously protected only by an IP-based
restriction to localhost.

Release note (security update): HTTP endpoints beginning with /debug/
now require a valid admin login session.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdarnell bdarnell force-pushed the backport19.2-50483 branch from 30baa5e to fc1e73e Compare June 22, 2020 17:16
These legacy endpoints were previously protected only by an IP-based
restriction to localhost.

Release note (security update): HTTP endpoints beginning with /debug/
now require a valid admin login session.
@bdarnell bdarnell force-pushed the backport19.2-50483 branch from fc1e73e to 02a2d18 Compare June 22, 2020 19:36
@bdarnell bdarnell merged commit ade6bf2 into cockroachdb:release-19.2 Jun 22, 2020
@bdarnell bdarnell deleted the backport19.2-50483 branch June 22, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants