cli: remove unnecessary command line flags #5033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| parseDurationEnv("cockroach-max-offset", "max offset", &ctx.MaxOffset) |
There was a problem hiding this comment.
Environment variables are almost always all caps and separated with underscores. While this isn't required, people will look at us funny if we use lowercase env variables.
There was a problem hiding this comment.
I'll change them all up. Expect and updated PR in a few mins.
|
|
||
| resetEnvVar := func() { | ||
| // Reset all environment variables in case any were already set. | ||
| if err := os.Unsetenv("COCKROACH-LINEARIZABLE"); err != nil { |
|
LGTM |
BramGruneir
added a commit
that referenced
this pull request
Mar 9, 2016
cli: remove unnecessary command line flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4754
attn: @jseldess
This change is