server: Wrap ExternalStorage factory methods in externalStorageBuilder struct #50293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
miretskiy
approved these changes
Jun 16, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @adityamaru)
pkg/server/server.go, line 211 at r1 (raw file):
) (cloud.ExternalStorage, error) { if !e.initCalled { return nil, errors.New("init not called before using externalStorageBuilder")
maybe "cannot create external storage before init"?
adityamaru
force-pushed
the
split-create-init
branch
from
d004c88 to
fecc4cd
Compare
adityamaru
commented
Jun 16, 2020
There was a problem hiding this comment.
Reviewable status:
pkg/server/server.go, line 211 at r1 (raw file):
Previously, miretskiy (Yevgeniy Miretskiy) wrote…
maybe "cannot create external storage before init"?
Done.
…r struct Previously, we initialized the ExternalStorage factory methods on creation of a NewServer() as all the required config params were ready-to-use. With future work related to user scoped storage requiring access to the underlying storage.Engine, this change introduces a wrapper around these factory methods. Using a builder struct allows us to split the "creation" and "initialization" of the builder between the NewServer() and Start() methods respectively. This allows for params which are only initialized on server.Start() to be propogated to the builder for future use. This is part of a gradual refactor of the ExternalStorage factory interface and is primarily to unblock development of cockroachdb#47211. Release note: None
adityamaru
force-pushed
the
split-create-init
branch
from
fecc4cd to
c3b8bcd
Compare
|
Rebased and retrying. There was a flake on |
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we initialized the ExternalStorage factory methods on
creation of a NewServer() as all the required config params were
ready-to-use.
With future work related to user scoped storage requiring access to the
underlying storage.Engine, this change introduces a wrapper around these
factory methods. Using a builder struct allows us to split the
"creation" and "initialization" of the builder between the NewServer()
and Start() methods respectively. This allows for params which are only
initialized on server.Start() to be propogated to the builder for future
use.
This is part of a gradual refactor of the ExternalStorage factory
interface and is primarily to unblock development of #47211.
Release note: None