Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logictest: add -print-blocklist-issues flag #50267

Merged
merged 1 commit into from
Jun 16, 2020
Merged

logictest: add -print-blocklist-issues flag #50267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion pkg/sql/logictest/logic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,14 @@ import (
//
// # LogicTest: !3node-tenant
//
// An issue can optionally be specified as the reason for blocking a given
// configuration:
//
// # LogicTest: !3node-tenant(<issue number>)
//
// A link to the issue will be printed out if the -print-blocklist-issues flag
// is specified.
//
// The Test-Script language is extended here for use with CockroachDB. The
// supported directives are:
//
Expand Down Expand Up @@ -399,6 +407,10 @@ var (
"optimizer-cost-perturbation", 0,
"randomly perturb the estimated cost of each expression in the query tree by at most the "+
"given fraction for the purpose of creating alternate query plans in the optimizer.")
printBlocklistIssues = flag.Bool(
"print-blocklist-issues", false,
"for any test files that contain a blocklist directive, print a link to the associated issue",
)
)

type testClusterConfig struct {
Expand Down Expand Up @@ -1448,7 +1460,7 @@ func processConfigs(t *testing.T, path string, configNames []string) []logicTest
}

blockedConfig, issueNo := getBlocklistIssueNo(configName[1:])
if issueNo != 0 {
if *printBlocklistIssues && issueNo != 0 {
t.Logf("will skip %s config in test %s due to issue: %s", blockedConfig, path, unimplemented.MakeURL(issueNo))
}
blocklist[blockedConfig] = issueNo
Expand Down