Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: run EXPLAIN ANALYZE (DEBUG) in tpchvec/perf on failure #50253

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

yuzefovich
Copy link
Member

In order to get more information that could explain occasional slowness
on query 7 this commit updates the usage of EXPLAIN ANALYZE to
EXPLAIN ANALYZE (DEBUG) which will provide us with traces and other
useful information. The bundles are curled into logs folder so that
the test runner fetched it alongside normal log files.

Addresses: #50029.

Release note: None

In order to get more information that could explain occasional slowness
on query 7 this commit updates the usage of `EXPLAIN ANALYZE` to
`EXPLAIN ANALYZE (DEBUG)` which will provide us with traces and other
useful information. The bundles are `curl`ed into `logs` folder so that
the test runner fetched it alongside normal log files.

Release note: None
@yuzefovich yuzefovich requested a review from asubiotto June 16, 2020 03:06
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@asubiotto asubiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Nice. Is EXPLAIN ANALYZE (DEBUG) available on all versions this test runs against?

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

Copy link
Member Author

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Is EXPLAIN ANALYZE (DEBUG) available on all versions this test runs against?

I didn't think about this initially, but the command is present on 20.1 version and onwards. tpchvec/perf also runs on 19.2 version, but we haven't had a single random slow failure on 19.2 since we increased the slowness threshold to 1.5 like 3 months ago, so I think it should be ok to use this command. I see it as a temporary measure to try to understand the intermittent slowness on query 7 and intend on removing it once we figure that out.

TFTR!

bors r+

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@craig
Copy link
Contributor

craig bot commented Jun 16, 2020

Build succeeded

@craig craig bot merged commit b3069bd into cockroachdb:master Jun 16, 2020
@yuzefovich yuzefovich deleted the tpchvec branch June 16, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants