Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workload: rename leftover vectorize option 'auto' to 'on' #49559

Merged
merged 1 commit into from
May 26, 2020

Conversation

yuzefovich
Copy link
Member

Release note: None

@yuzefovich yuzefovich requested a review from asubiotto May 26, 2020 16:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@asubiotto asubiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: I assume we don't care about versions in workload

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @asubiotto)

Copy link
Member Author

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have the same assumption. And if someone wants to run the workload against an old cluster, they will have to manually specify the vectorize option.

TFTR!

bors r+

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@craig
Copy link
Contributor

craig bot commented May 26, 2020

Build succeeded

@craig craig bot merged commit e3f2142 into cockroachdb:master May 26, 2020
@yuzefovich yuzefovich deleted the vectorize-auto-leftover branch May 26, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants