sql/catalog: rename ObjectDescriptor to Descriptor #49555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're trying to define Object as a member of a schema. Today that's not really true because Objects are currently members of databases and not schemas but we'll get there. Descriptor is the general term for all entities which are in the catalog, resolvable by a name, and live in the descriptor table. Release note: None
ajwerner
added
the
A-schema-descriptors
|
This change is |
ajwerner
added
the
C-cleanup
rohany
approved these changes
May 26, 2020
thoszhang
approved these changes
May 26, 2020
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
TFTR! bors r=lucy-zhang,rohany |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're trying to define Object as a member of a schema. Today that's not really
true because Objects are currently members of databases and not schemas but
we'll get there. Descriptor is the general term for all entities which are in
the catalog, resolvable by a name, and live in the descriptor table.
Release note: None