sql: deal with retriable errors in DROP INDEX
#49221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
force-pushed
the
ajwerner/close-issue-hopefully-fixed-by-using-user-txn-for-planning
branch
from
e5f77ee to
24e999f
Compare
thoszhang
approved these changes
May 19, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @spaskob)
Prior to this commit we would assume any error while retrieving a descriptor during the execution of `DROP INDEX` was an assertion failure. This was overly paranoid. Plenty of retriable errors are possible (and furthermore so are errors due to shutdown). The only error we should freak out about is if we discover the relation is not defined. Fixes cockroachdb#48474. Release note (bug fix): Fix bug where contended `DROP INDEX` queries return an assertion failure error rather than a retriable error.
ajwerner
force-pushed
the
ajwerner/close-issue-hopefully-fixed-by-using-user-txn-for-planning
branch
from
24e999f to
1d421da
Compare
spaskob
reviewed
May 19, 2020
There was a problem hiding this comment.
lgtm
Reviewable status:
|
TFTR! bors r=spaskob,lucy-zhang |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit we would assume any error while retrieving a descriptor
during the execution of
DROP INDEXwas an assertion failure. This wasoverly paranoid. Plenty of retriable errors are possible (and furthermore
so are errors due to shutdown). The only error we should freak out about
is if we discover the relation is not defined.
Fixes #48474.
Release note (bug fix): Fix bug where contended
DROP INDEXqueries returnan assertion failure error rather than a retriable error.