vendor: bump grpc to v1.27.1

[tbg]

Upgrade gRPC to 1.27.1 (latest is 1.29). This doesn't pick up anything that we need, but it claims to contain some improvements, and now is the right time in the cycle to bump if we're going to.

TODO: does this want a release note?

Notable PRs (from gRPC-go's release notes):

• client: fix race between client-side stream cancellation and compressed server data arriving (client: fix race between client-side stream cancellation and compressed server data arriving grpc/grpc-go#3054)
• clientconn: fix potential deadlock caused by ResetConnectBackoff (clientconn: fix potential deadlock caused by ResetConnectBackoff grpc/grpc-go#3051)
• internal: fix context leak when stream is not created successfully (internal: fix context leak when stream is not created successfully grpc/grpc-go#2985)
• server: set and advertise max frame size of 16KB (server: set and advertise max frame size of 16KB grpc/grpc-go#3018)
• transport: block reading frames when too many transport control frames are queued (transport: block reading frames when too many transport control frames are queued grpc/grpc-go#2970)
  Addresses CVE-2019-9512 (Ping Flood), CVE-2019-9514 (Reset Flood), and CVE-2019-9515 (Settings Flood).
• server: avoid an unnecessary allocation per-RPC for OK status (server: avoid an unnecessary allocation per-RPC for OK status grpc/grpc-go#2920)
  Special Thanks: @dzbarsky
• server: avoid call to trace.FromContext and resulting allocations when tracing is disabled (server: avoid call to trace.FromContext and resulting allocations when tracing is disabled grpc/grpc-go#2926)
  Special Thanks: @dzbarsky
• http2client: remove unnecessary allocations for header fields (http2client: remove unnecessary allocations for header fields grpc/grpc-go#2925)
  Special Thanks: @dzbarsky
• status: avoid allocations when returning an OK status (status: avoid allocations when returning an OK status grpc/grpc-go#2929)
  Special Thanks: @dzbarsky
• server: avoid allocations related to tracking excessive pings (server: avoid allocations related to tracking excessive pings grpc/grpc-go#2923)
  Special Thanks: @dzbarsky
• transport: call Unlock in defer to avoid data race (transport: call Unlock in defer to avoid data race grpc/grpc-go#2953)
• client: fix canceled vs deadline exceeded double-check logic (client: fix canceled vs deadline exceeded double-check logic grpc/grpc-go#2906)
• client: fix race between transport draining and new RPCs (client: fix race between transport draining and new RPCs grpc/grpc-go#2919)

Release note (general change): gRPC was updated from 1.21 to 1.27.1.

[cockroach-teamcity]

This change is 

[petermattis]

I'm not sure about the release note. This isn't a user visible change, nor does it fix any known bugs. @knz might have a stronger opinion.

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @petermattis)

[knz]

The first change gets rid of Decompressor is not installed for grpc-encoding "gzip" which we know was happening at least in the cli quit so that's code we can simplify.

The last one was cause of log spam when nodes disconnect in the cluster.

For the first one no need for a release note because of the code I added to hide the error, but maybe remove that code or file the cleanup issue and assign it to me.

The last one may or may not need a release note, but that's something that support may want to be pinged about.

[tbg]

Of course there's a yak shave. Bumping grpc updates this file

https://github.com/grpc/grpc-go/blob/master/health/grpc_health_v1/health.pb.go#L25

Note the IsV3 - used to be IsV2. (the file is included as a dependency via etcd)

This in turn requires us to update github.com/golang/protobuf to v1.4+

At that version, github.com/golang/protobuf/protoc-gen-go/generator/generator.go

emits a warning at init() time:

WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated.
A future release of golang/protobuf will delete this package,
which has long been excluded from the compatibility promise.

We treat warnings as errors in protoc, so now make protobuf fails. I want to continue treating warnings as errors.

Still pulling on this and trying to understand who actually pulls that package in and whether we can convince them to use the suggested replacement package google.golang.org/protobuf/compiler/protogen. I hope it's not gogo/protobuf but I'll probably find that it is (gogoproto is not well maintained any more).

[tbg]

Here are the importers:

go list -f '{{.ImportPath}} {{join .Imports " "}}' ./pkg/... ./vendor/... | digraph reverse github.com/cockroachdb/cockroach/vendor/github.com/golang/protobuf/protoc-gen-go/generator
github.com/cockroachdb/cockroach/vendor/github.com/golang/protobuf/protoc-gen-go/generator
github.com/cockroachdb/cockroach/vendor/github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway
github.com/cockroachdb/cockroach/vendor/github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway/descriptor
github.com/cockroachdb/cockroach/vendor/github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway/generator
github.com/cockroachdb/cockroach/vendor/github.com/grpc-ecosystem/grpc-gateway/protoc-gen-grpc-gateway/gengateway
github.com/cockroachdb/cockroach/vendor/github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger
github.com/cockroachdb/cockroach/vendor/github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger/genswagger

Well that sucks.

[tbg]

Ok I might have it. grpc-gateway bump did the trick. Verifying now.

[tbg]

Ugh. So after grpc-gateway bump its protoc plugin started emitting warnings for RPCs that didn't have a HttpRule. I tried using

    option (google.api.http) = {    };

which almost works except pbjs throws up:

/home/tschottdorf/go/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/protobufjs/cli/pbjs.js:235
            throw err;
            ^

Error: illegal name '}' (pkg/server/serverpb/admin.proto, line 868)
    at illegal (/home/tschottdorf/go/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/protobufjs/src/parse.js:94:16)

Others have complained about this warning as well but the outcome is unfortunately that the warning stayed and Uber (the "others") wrapped their prototool to remove the warning from stderr. What a waste of everyone's time.

grpc-ecosystem/grpc-gateway@ee51345

As it stands, it seems that we're going to have to wrap the grpc-gateway gen tool, I think?

[tbg]

I'm going to fork grpc-gateway and nuke the warning message instead.

[tbg]

Ok this should now build. @petermattis mind giving this another look?

[petermattis]

though I hope the Gopkg.toml changes haven't made a switch to go mod more difficult.

Reviewable status: complete! 1 of 0 LGTMs obtained

[tbg]

@otan / @jordanlewis (I think you're still team go mod, right?) want me to hold off here? I'm happy figuring all of the above out in a go mod world one more time provided it looks like go mod is still en route to success soonish.

[jordanlewis]

We already have a bunch of Gopkg.toml changes since our first cut. We're going to have to completely redo it anyway. So I don't think this is going to make thigns much worse, right @otan?

[otan]

yep, going to have to re-do it. feel free to further ahead / get this in (before Friday would be great)

[tbg]

bors r=petermattis

[craig]

Build failed

• GitHub CI (Cockroach)

[tbg]

bors r=petermattis

Filed #49359 for the issue @knz mentioned.

cc @roncrdb about #49114 (comment) (sorry, not sure how to ping "support" from an issue).

[craig]

Merge conflict

[tbg]

Had to re-do the vendor dir due to merge skew

bors r=petermattis

[tbg]

Build is not running, dear bors

bors r-

[craig]

Canceled

[tbg]

bors r=petermattis

[craig]

Build succeeded

• GitHub CI (Cockroach)