smithcmp: rename auto to 201auto in tpch config files #48503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
asubiotto
approved these changes
May 7, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @asubiotto)
|
TFTR! bors r+ |
|
I think we should remove bors r- |
Canceled |
This commit also removes `auto` option from `tpchvec_smithcmp.toml` config file because that option has different names in 20.2 and 20.1, and we run the test on both. The alternative is to introduce a separate config file, but I don't think `auto` option gives us much more test coverage than already present `off` and `on` do. Release note: None
|
Updated, PTAL. |
asubiotto
approved these changes
May 7, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:
|
TFTR! bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also removes
autooption fromtpchvec_smithcmp.tomlconfig file because that option has different names in 20.2 and 20.1,
and we run the test on both. The alternative is to introduce a separate
config file, but I don't think
autooption gives us much more testcoverage than already present
offandondo.Fixes: #48484.
Release note: None