release-19.2: rowexec: account for some additional memory used by stats collection #48342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, we did not account for the memory used in the sampleAggregator when we copy all samples into a new slice before generating a histogram. This commit adds some additional memory accounting for this overhead. Informs cockroachdb#45812 Release note: None
|
This change is |
RaduBerinde
approved these changes
May 4, 2020
yuzefovich
approved these changes
May 4, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #47106.
/cc @cockroachdb/release
Prior to this commit, we did not account for the memory used in the
sampleAggregatorwhen we copy all samples into a new slice beforegenerating a histogram. This commit adds some additional memory
accounting for this overhead.
Informs #45812
Release note: None