roachtest: fail tpcdsvec test with an error #47974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
asubiotto
suggested changes
Apr 27, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @asubiotto and @yuzefovich)
pkg/cmd/roachtest/tpcdsvec.go, line 202 at r1 (raw file):
} if lastErr != nil { t.Fatal(lastErr)
Can we somehow accumulate errors and display them all?
In `tpcdsvec` test we run all the queries even we hit an error. Previously if an error occurred, we would just fail the test, and now we will be failing with an error that is a "combination" of all occurred errors. Release note: None
yuzefovich
commented
Apr 27, 2020
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/tpcdsvec.go, line 202 at r1 (raw file):
Previously, asubiotto (Alfonso Subiotto Marqués) wrote…
Can we somehow accumulate errors and display them all?
Done.
|
❌ The GitHub CI (Cockroach) build has failed on c0a483de. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
asubiotto
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
|
TFTR! bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
tpcdsvectest we run all the queries even we hit an error.Previously if an error occurred, we would just fail the test, and now we
will be failing with an error that is a "combination" of all occurred
errors.
Addresses: #47889.
Release note: None