colexec, coldata: fix compiler warnings in template files #47953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This commit fixes all compiler warnings that I see in Goland. To get there it does the following: 1. renames `Vec._TemplateType` to `Vec.TemplateType` so that the method is considered exported 2. pulls out declaration of local variables outside of templated `if` blocks 3. breaks up the chained function call to parse flags in `pkg/workload` and a few other places so that there is an allocation of a struct and we can call a method on it that has a pointer receiver. It shouldn't matter for the performance though. Release note: None
yuzefovich
force-pushed
the
fix-compiler-warnings
branch
from
be55feb to
0b2fd2b
Compare
|
❌ The GitHub CI (Cockroach) build has failed on 0b2fd2ba. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
asubiotto
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Reviewed 8 of 38 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @asubiotto)
|
TFTR! bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes all compiler warnings that I see in Goland. To get
there it does the following:
Vec._TemplateTypetoVec.TemplateTypeso that the methodis considered exported
ifblocks
pkg/workloadand a few other places so that there is an allocation of a struct and we
can call a method on it that has a pointer receiver. It shouldn't matter
for the performance though.
Release note: None