release-19.2: opt: fix in-place modification of window definition in optbuilder #47716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The optbuilder code which handles window functions inadvertently modifies the `WindowDef` in place. This leads to loss of qualification in the PARTITION BY and ORDER BY columns (which get replaced with `*scopeColumn`s). This is a problem for views where the query stored in the descriptor could be invalid without the qualification. This change fixes this by making copies as necessary. Fixes cockroachdb#47704. Release note (bug fix): fixed case where PARTITION BY and ORDER BY columns in window specifications were losing qualifications when used inside views.
|
This change is |
rytaft
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
❌ The GitHub CI (Cockroach) build has failed on 5f3d080d. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #47715.
/cc @cockroachdb/release
The optbuilder code which handles window functions inadvertently modifies the
WindowDefin place. This leads to loss of qualification in the PARTITION BYand ORDER BY columns (which get replaced with
*scopeColumns). This is aproblem for views where the query stored in the descriptor could be invalid
without the qualification.
This change fixes this by making copies as necessary.
Fixes #47704.
Release note (bug fix): fixed case where PARTITION BY and ORDER BY columns in
window specifications were losing qualifications when used inside views.