kv: deflake TestInitRaftGroupOnRequest #47625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#42808. Fixes cockroachdb#44146. Fixes cockroachdb#47020. Fixes cockroachdb#47551. Fixes cockroachdb#47231. Disable async intent resolution. This can lead to flakiness in the test because it allows for the intents written by the split transaction to be resolved at any time, including after the nodes are restarted. The intent resolution on the RHS's local range descriptor intent can both wake up the RHS range's Raft group and result in the wrong replica acquiring the lease. I was always seeing this in conjunction with the log line: ``` kv/kvserver/intentresolver/intent_resolver.go:746 failed to gc transaction record: could not GC completed transaction anchored at /Local/Range/Table/50/RangeDescriptor: node unavailable; try another peer ``` Before the fix, the test failed almost immediately when stressed on a roachprod cluster. After, I've never seen it flake: ``` 576962 runs so far, 0 failures, over 19m35s ``` I think this may have gotten more flaky after we began batching intent resolution, as this batching also introduced a delay to the async task. I'll backport this to the past few release branches.
|
This change is |
tbg
approved these changes
Apr 17, 2020
|
bors r+ |
Build failed |
|
#45337 flaked. bors r+ |
Build succeeded |
This was referenced Apr 18, 2020
nvanbenschoten
deleted the
nvanbenschoten/deflakeTestInitRaftGroupOnRequest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42808.
Fixes #44146.
Fixes #47020.
Fixes #47551.
Fixes #47231.
Disable async intent resolution. This can lead to flakiness in the test
because it allows for the intents written by the split transaction to be
resolved at any time, including after the nodes are restarted. The intent
resolution on the RHS's local range descriptor intent can both wake up
the RHS range's Raft group and result in the wrong replica acquiring the
lease.
I was always seeing this in conjunction with the log line:
Before the fix, the test failed almost immediately when stressed on a roachprod
cluster. After, I've never seen it flake:
I think this may have gotten more flaky after we began batching intent
resolution, as this batching also introduced a delay to the async task.
I'll backport this to the past few release branches.