Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logictest: fix error matching in vectorize_types test #47130

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

yuzefovich
Copy link
Member

Vectorized engine will emit slightly different error for unsupported
type depending on whether the query runs locally or in distributed
fashion. We added fakedist-vec config to vectorize_types logic test
recently, so we need to make error matching more flexible in there.

Fixes: #47111.

Release note: None

Vectorized engine will emit slightly different error for unsupported
type depending on whether the query runs locally or in distributed
fashion. We added `fakedist-vec` config to `vectorize_types` logic test
recently, so we need to make error matching more flexible in there.

Release note: None
@yuzefovich yuzefovich requested a review from a team April 7, 2020 15:41
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 7, 2020

Build failed (retrying...)

@craig
Copy link
Contributor

craig bot commented Apr 7, 2020

Build failed (retrying...)

@yuzefovich
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 7, 2020

Build succeeded

@craig craig bot merged commit 6df26fd into cockroachdb:master Apr 7, 2020
@yuzefovich yuzefovich deleted the fix-vec-error branch April 7, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql/logictest: TestLogic failed
3 participants