Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: Bump pebble to 74d69792cb150369fb7a799be862524ad2b39d51 #46871

Merged
merged 1 commit into from
Apr 1, 2020
Merged

vendor: Bump pebble to 74d69792cb150369fb7a799be862524ad2b39d51 #46871

merged 1 commit into from
Apr 1, 2020

Conversation

itsbilal
Copy link
Contributor

@itsbilal itsbilal commented Apr 1, 2020

Pulls in these changes:

  • *: use errors.Errorf in replace of fmt.Errorf
  • *: use github.com/cockroachdb/errors
  • vendor: add cockroachdb/errors and its dependencies
  • *: add FileNum type
  • db: delete orphaned temporary files in Open
  • version_set: Handle case where RocksDB doesn't bump minUnflushedLogNum
  • db: modify Options.DebugCheck to be a function
  • internal/manifest: Relax SeqNum overlap invariant in L0
  • internal/metamorphic: fix ingest_using_apply implementation
  • *: use Go 1.13 error wrapping
  • internal/metamorphic: randomize MaxConcurrentCompactions
  • internal/metamorphic: enable run comparison by default
  • internal/metamorphic: temporarily disable ingest_using_apply
  • db: document that Close may not be called twice
  • db: use require.* functions for test checks
  • *: use require.NoError everywhere
  • internal/errorfs: move to new package

Release note: None

@itsbilal
vendor: Bump pebble to 74d69792cb150369fb7a799be862524ad2b39d51
4ef2d9a 
Pulls in these changes:
 - *: use errors.Errorf in replace of fmt.Errorf
 - *: use github.com/cockroachdb/errors
 - vendor: add cockroachdb/errors and its dependencies
 - *: add FileNum type
 - db: delete orphaned temporary files in Open
 - version_set: Handle case where RocksDB doesn't bump minUnflushedLogNum
 - db: modify Options.DebugCheck to be a function
 - internal/manifest: Relax SeqNum overlap invariant in L0
 - internal/metamorphic: fix ingest_using_apply implementation
 - *: use Go 1.13 error wrapping
 - internal/metamorphic: randomize MaxConcurrentCompactions
 - internal/metamorphic: enable run comparison by default
 - internal/metamorphic: temporarily disable ingest_using_apply
 - db: document that Close may not be called twice
 - db: use require.* functions for test checks
 - *: use require.NoError everywhere
 - internal/errorfs: move to new package

Release note: None
@itsbilal itsbilal requested review from jbowens and petermattis April 1, 2020 19:34
@itsbilal itsbilal self-assigned this Apr 1, 2020
@cockroach-teamcity
Copy link
Member

This change is Reviewable

petermattis
petermattis approved these changes Apr 1, 2020
View reviewed changes
Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsbilal
Copy link
Contributor Author

itsbilal commented Apr 1, 2020

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 1, 2020

Build succeeded

@craig craig bot merged commit 3b3c470 into cockroachdb:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermattis petermattis petermattis approved these changes

@jbowens jbowens Awaiting requested review from jbowens

Assignees

@itsbilal itsbilal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itsbilal @cockroach-teamcity @petermattis