release-19.2: sql: prevent arbitrary writes to system.comments #46833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the GRANT, UPDATE, DELETE and INSERT privileges were granted to `public`, i.e. everyone, on `system.comments`. This was unintended - only users with permissions on an object should be able to modify that object's comments. This patch fixes it. Release note (security update): Any user could previously modify any database/table/view/index comment via direct SQL updates to `system.comments`. This was unintended and a form of privilege escalation, and is now prevented. The privileges required for the COMMENT statement and `pg_description`, `col_description()`, `obj_description()` and `shobj_description()` are operating as in PostgreSQL and unaffected by this change: all users can *view* any comments on any object (bypassing other privileges), but modifying comments require write privilege on the target object.
|
This change is |
RichardJCai
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #45712.
/cc @cockroachdb/release
Fixes #45707.