Revert "sql: use user transaction if we have one to prepare queries" #46811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This reverts commit 0b945bf. Release note: None
ajwerner
force-pushed
the
ajwerner/revert-use-user-txn
branch
from
fdedc00 to
ca04d18
Compare
|
Say something in the commit msg about how it appears that we don't like retriable error events when there's no transaction in progress |
|
The problem is that if we got an error which can be retried but we used a new transaction then we should make sure that doesn't get turned into a retriable error for the state machine. One question I have is whether we should run the prepare inside of a |
|
Abandoning in favor of #46829. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0b945bf.
Release note: None