gcjob: fix race in gc job test #46792
Merged
+23
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
In the GC job test, the table descriptors were updated after creating the job. Most of the time, the table descriptors were by the time the GC job actually started running, but sometimes they would not be. This lead to the GC job not noticing the dropped tables and therefore take too long to complete (as it would wait another 5 minutes to check again). This change ensures that the table descriptors are updated before the GC job is created. Release justification: only touches testing code, and fixes a flake. Release note: None
|
Stressed this branch locally and am at 3000 passes and no failures. |
thoszhang
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
TFTR! |
83 tasks
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the GC job test, the table descriptors were updated after creating
the job. Most of the time, the table descriptors were by the time the GC
job actually started running, but sometimes they would not be. This lead
to the GC job not noticing the dropped tables and therefore take too
long to complete (as it would wait another 5 minutes to check again).
This change ensures that the table descriptors are updated before the GC
job is created.
Fixes #46767.
Release justification: only touches testing code, and fixes a flake.
Release note: None