release-20.1: backupccl: add telemetry #46755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: none. Release justification: extremely minor change.
This adds counters to usage of various features of BACKUP and RESTORE: - if encryption is used - if full-cluster is used - if incremental is used, either explicitly or automatically - total, succeeded and failed counts as well as runtime, size and throughput These should help us measure how BACKUP and RESTORE are used and are behaving in the wild and where to direct our future efforts. Release note (enterprise change): BACKUP and RESTORE now collect some anonymous telemetry on throughput and feature usage. Release justification: low-risk, high impact.
|
This change is |
pbardea
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #46716.
/cc @cockroachdb/release
This adds counters to usage of various features of BACKUP and RESTORE:
These should help us measure how BACKUP and RESTORE are used and are behaving in the wild and where to direct our future efforts.
Fixes #46518
Fixes #46520
Fixes #46521
Release note (enterprise change): BACKUP and RESTORE now collect some anonymous telemetry on throughput and feature usage.
Release justification: low-risk, high impact.