build: do not fail RocksDB build on compiler warnings #46673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
@rytaft This fixes the RocksDB / jemalloc build error seen when using the most recent version of Xcode. |
knz
approved these changes
Mar 27, 2020
Makefile
Outdated
| @@ -643,7 +643,7 @@ $(ROCKSDB_DIR)/Makefile: $(C_DEPS_DIR)/rocksdb-rebuild | bin/.submodules-initial | |||
| $(if $(use-stdmalloc),,-DJEMALLOC_LIBRARIES=$(LIBJEMALLOC) -DJEMALLOC_INCLUDE_DIR=$(JEMALLOC_DIR)/include -DWITH_JEMALLOC=ON) \ | |||
| -DCMAKE_BUILD_TYPE=$(if $(ENABLE_ROCKSDB_ASSERTIONS),Debug,Release) \ | |||
| -DFAIL_ON_WARNINGS=$(if $(findstring windows,$(XGOOS)),0,1) \ | |||
There was a problem hiding this comment.
can you edit that line too then
There was a problem hiding this comment.
Oh, didn't even notice that. I've removed it now that we're disabling failing on warnings everywhere.
Disable `-Werror` for the RocksDB build which has recently started complaining about a missing exception specification in a jemalloc header with the newest version of Xcode. Release justification: low risk change to remove developer build irritation. Should be a no-op for production builds. Release note: None
petermattis
force-pushed
the
pmattis/rocksdb-compiler-errors
branch
from
7148b45 to
7f61159
Compare
rytaft
reviewed
Mar 27, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @knz and @rytaft)
|
TFTR! bors r+ |
|
This appears to have been canceled because of missing cla check on one of my PRs. bors r+ |
Build succeeded |
This was referenced Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable
-Werrorfor the RocksDB build which has recently startedcomplaining about a missing exception specification in a jemalloc header
with the newest version of Xcode.
Release justification: low risk change to remove developer build
irritation. Should be a no-op for production builds.
Release note: None