opt: better error message for unsupported UNION variant of recursive CTEs #46643
Conversation
|
This change is |
|
@awoods187 the new error looks like this, let me know if it's ok: |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
pkg/sql/opt/optbuilder/testdata/with, line 1146 at r1 (raw file):
└── "?column?":8 => b:10 build
Maybe add a comment to say that this doesn't cause an error since there's no recursive reference
…CTEs Postgres supports a variant of recursive CTEs that uses UNION instead of UNION ALL. We don't support it as of yet; this commit improves the error returned in this case. Fixes cockroachdb#46378. Release note: None Release justification: low risk change to new functionality.
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/sql/opt/optbuilder/testdata/with, line 1146 at r1 (raw file):
Previously, rytaft (Rebecca Taft) wrote…
Maybe add a comment to say that this doesn't cause an error since there's no recursive reference
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
|
bors r+ |
Build succeeded |
Postgres supports a variant of recursive CTEs that uses UNION instead
of UNION ALL. We don't support it as of yet; this commit improves the
error returned in this case.
Fixes #46378.
Release note: None
Release justification: low risk change to new functionality.