Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpccbench: bump EstimatedMax for tpccbench/nodes=9/cpu=4/multi-region #46585

Merged

Conversation

nvanbenschoten
Copy link
Member

@nvanbenschoten nvanbenschoten commented Mar 25, 2020

Closes #41876.

Searching from 2200 up to around 3000 each time this test runs takes a long
time and can lead to test timeouts. Now that we're more efficient, we can
bump the estimated max and limit the max warehouse search.

Release justification: testing only

See cockroachdb#41876.

Searching from 2200 up to around 3000 each time this test runs takes a long
time and can lead to test timeouts. Now that we're more efficient, we can
bump the estimated max and limit the max warehouse search.

Release justification: testing only
@nvanbenschoten nvanbenschoten requested a review from ajwerner March 25, 2020 19:52
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@nvanbenschoten
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 25, 2020

Build succeeded

@craig craig bot merged commit 6d81524 into cockroachdb:master Mar 25, 2020
@nvanbenschoten nvanbenschoten deleted the nvanbenschoten/multiRegionTPCC branch March 30, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: tpccbench/nodes=9/cpu=4/multi-region failed
3 participants