ui: Preserve search/sorting on Statements page #46575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search query and sorting params are preserved as URL search params. It doesn't break existing routing configuration and allows restore custom state from URL. Release note: None Release justification: bug fixes and low-risk updates to new functionality
Before, URL search params were removed when App filter changed, and this behavior introduced inconsistent state between defined URL params and actual state. Now, when App filter changes, URL search params updated as well. Release note: None Release justification: bug fixes and low-risk updates to new functionality
Before, on Statements page when user clears search statement, `q` url search param is not cleared Now, URL search param is cleared as well and preserves correct state. Release note: None Release justification: bug fixes and low-risk updates to new functionality
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #45404
Search query and sorting params are preserved as URL search
params. It doesn't break existing routing configuration and
allows restore custom state from URL.
Release justification: bug fixes and low-risk updates to new functionality