sql: fix metric logging for temporary objects cleaner #46269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was benchmarking temporary tables and found we didn't actually log these metrics properly. There was a bit of plumbing that I missed doing. This has been resolved and verified in this PR. Release justification: bug fixes and low-risk updates to new functionality Release note: None
|
This change is |
|
don't really know about this code area to review -- sorry |
jordanlewis
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @rohany)
|
bors r=jordanlewis don't think there's a test we can do to ensure it's plugged in :\ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was benchmarking temporary tables and found we didn't actually log these
metrics properly. There was a bit of plumbing that I missed doing. This
has been resolved and verified in this PR.
Release justification: bug fixes and low-risk updates to new
functionality
Release note: None