server: fix misleading TestJemalloc result for ppc64le #46255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This change is |
petermattis
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
Thanks for the fix. The CI failure looks unrelated. I'll poke CI to run again, and get this merged on green.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @petermattis)
|
Thanks for the review @petermattis ! |
|
@amitsadaphule Do you mind rebasing onto current master? The CI failures seem to be do to your old branch. |
|
@petermattis sure. I'll rebase the branch. |
The test failed on ppc64le since the 16KiB constant in allocateMemory
didn't exceed the thread cache on ppc64le. Brief failure log shown below:
```
=== RUN TestJemalloc
--- FAIL: TestJemalloc (0.00s)
jemalloc_test.go:37: allocated stat not incremented on allocation: 2322976
```
Configuring jemalloc with `--disable-tcache to disable the thread cache` or
flushing thread cache as `mallctl("thread.tcache.flush", NULL, NULL, NULL, 0);`
showed expected behavior. But had performance and code clutter trade-offs resp.
So, updated the constant to suit ppc64le which also works for x86 and others.
Release justification: Fixes misleading test result for jemalloc stat on PPC
Release note: None
amitsadaphule
force-pushed
the
testjemalloc_fix
branch
from
97e3afb to
baf61cb
Compare
|
@amitsadaphule Thanks. bors r+ |
Build failed |
|
Known / unrelated CI failure. Trying again. bors r+ |
Build failed (retrying...) |
|
Another unrelated CI failure (#43251). This PR doesn't want to go in. bors r+ |
|
Already running a review |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43522
The test failed on ppc64le since the 16KiB constant in allocateMemory
didn't exceed the thread cache on ppc64le. Brief failure log shown below:
Configuring jemalloc with
--disable-tcache to disable the thread cacheorflushing thread cache as
mallctl("thread.tcache.flush", NULL, NULL, NULL, 0);showed expected behavior. But had performance and code clutter trade-offs resp.
So, updated the constant to suit ppc64le which also works for x86 and others.
Release justification: Fixes misleading test result for jemalloc stat on PPC
Release note: None