ui: removed metric function setDefaultTime
#46190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dhartunian
approved these changes
Mar 25, 2020
There was a problem hiding this comment.
Looks good. Didn't know we had this feature previously.
Going to just confirm with Piyush that we want that old feature removed.
Please add a Release Justification to commit and PR message so we can merge :)
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
vladlos
force-pushed
the
fix/default-graph-time-window
branch
from
00cd0bc to
bd85d45
Compare
|
@elkmaster can you fix the merge conflict so we can merge? |
|
This will also need a release note: "default timescale on metrics page is always 10m. previously it defaulted to the age of the longest running node" |
vladlos
force-pushed
the
fix/default-graph-time-window
branch
from
bd85d45 to
d63789f
Compare
Removed setter the default graph time window based on the age of the older node in the cluster because we have default redux scale. That fixed our problem when we using the time dropdown on the metrics page and clicking on "10m" we get result with "6h" duration. Resolves: cockroachdb#46145 Release justification: bug fixes and low-risk updates to new functionality Release note (ui): default timescale on metrics page is always 10m. previously it defaulted to the age of the longest running node
vladlos
force-pushed
the
fix/default-graph-time-window
branch
from
d63789f to
7abc4d2
Compare
|
bors r+ |
Build succeeded |
This was referenced Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed setter the default graph time window based on the age of the older node in the cluster because we have default redux scale. That fixed our problem when we using the time dropdown on the metrics page and clicking on "10m" we get result with "6h" duration.
Resolves: #46145
Release justification: bug fixes and low-risk updates to new functionality
Release note (ui): default timescale on metrics page is always 10m. previously it defaulted to the age of the longest running node