Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: remove experimental prefix from opt-driven FK settings #46174

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

RaduBerinde
Copy link
Member

Release note (sql change): renamed experimental_optimizer_foreign_keys session
setting and sql.defaults.optimizer_foreign_keys.enabled cluster setting to
remove the experimental prefix.

Release justification: bug fixes and low-risk updates to new functionality.

Release note (sql change): renamed `experimental_optimizer_foreign_keys` session
setting and `sql.defaults.optimizer_foreign_keys.enabled` cluster setting to
remove the experimental prefix.

Release justification: bug fixes and low-risk updates to new functionality.
@RaduBerinde RaduBerinde requested a review from rytaft March 16, 2020 23:53
@RaduBerinde RaduBerinde requested a review from a team as a code owner March 16, 2020 23:53
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@andy-kimball andy-kimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rytaft)

Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 14 of 14 files at r1.
Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained

@RaduBerinde
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 17, 2020

Build succeeded

@craig craig bot merged commit c4426dd into cockroachdb:master Mar 17, 2020
@RaduBerinde RaduBerinde deleted the fk-not-experimental branch March 17, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants