github-pull-request-make: set minimum testrace duration per test #46138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This change updates the minimum allowed duration for a test run under race in CI to be configured on a per-test basis, rather than a per-package basis. When there are a lot of tests in a given package that need to be stressed by testrace, the entire package may not be given sufficient time to complete. For example, cockroachdb#45962 was not passing CI since many tests were changed within one package. Release justification: Non-production code changes. Release note: None
pbardea
changed the title
tbg
approved these changes
Mar 16, 2020
|
TFTR! |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the minimum allowed duration for a test run under
race in CI to be configured on a per-test basis, rather than a
per-package basis.
When there are a lot of tests in a given package that need to be
stressed by testrace, the entire package may not be given sufficient
time to complete. For example, #45962 was not passing CI since many
tests were changed within one package.
Release justification: Non-production code changes.
Release note: None