Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgwire: add telemetry for portal related requests #46099

Merged

Conversation

otan
Copy link
Contributor

@otan otan commented Mar 13, 2020

Resolves #43763 by covering the happy case.

This PR adds telemetry everytime a "limitedCommandResult" is made, which
signifies jdbc streaming.

Release justification: simply telemetry.

Release note: None

@otan otan requested review from rohany and a team March 13, 2020 20:47
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan
Copy link
Contributor Author

otan commented Mar 13, 2020

unrelated video: https://www.youtube.com/watch?v=5U1_KW6ww7Y

This PR adds telemetry everytime a "limitedCommandResult" is made, which
signifies jdbc streaming.

Release justification: simply telemetry.

Release note: None
@otan otan force-pushed the telemetry_phjdbfduhifaduo_streaming branch from 7bba47a to 76f5997 Compare March 13, 2020 21:46
@rohany
Copy link
Contributor

rohany commented Mar 13, 2020

l g t m

@otan
Copy link
Contributor Author

otan commented Mar 16, 2020

bors r=rohany

@craig
Copy link
Contributor

craig bot commented Mar 16, 2020

Build failed (retrying...)

@craig
Copy link
Contributor

craig bot commented Mar 16, 2020

Build succeeded

@craig craig bot merged commit 06fdc13 into cockroachdb:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: add telemetry for improve streaming behavior on JDBC driver
3 participants