workload, logictest: fix miscellaneous TODOs related to TPCH #46034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
asubiotto
suggested changes
Mar 13, 2020
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @yuzefovich)
pkg/workload/querybench/query_bench.go, line 134 at r1 (raw file):
// Fall back to using the pre-19.2 syntax. // TODO(asubiotto): Remove this once we stop running this test against // 19.1.
How are we sure we don't run this against 19.1 anymore?
yuzefovich
force-pushed
the
fix-tpch-todos
branch
from
1a70c51 to
080d567
Compare
yuzefovich
commented
Mar 13, 2020
There was a problem hiding this comment.
Reviewable status:
pkg/workload/querybench/query_bench.go, line 134 at r1 (raw file):
Previously, asubiotto (Alfonso Subiotto Marqués) wrote…
How are we sure we don't run this against 19.1 anymore?
Good point. I think we can now bump the minimum version in tpchbench roachtest.
Release justification: non-production code changes. Release note: None
yuzefovich
force-pushed
the
fix-tpch-todos
branch
from
080d567 to
1bcdc3c
Compare
|
Friendly ping. |
asubiotto
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:
|
TFTR! bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release justification: non-production code changes.
Release note: None