roachtest: more informatively tear down after timeout #45887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nvanbenschoten
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)
|
bors r=nvanbenschoten |
Build failed |
When a test times out and fails to respond to cancellation, we already dump the roachtest stacks (=test side of the hang). With this commit, we additionally dump stacks for any processes running on remote machines (=server side of the hang). Additionally, this might improve our odds at actually nudging the test to terminate than we did previously. (Though the context cancellation ought to also have killed all processes). Release justification: roachtest-only change Release note: None
|
there was a release justification. Let's try again with one added to PR bors r=nvanbenschoten |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a test times out and fails to respond to cancellation, we already
dump the roachtest stacks (=test side of the hang).
With this commit, we additionally dump stacks for any processes
running on remote machines (=server side of the hang).
Additionally, this might improve our odds at actually nudging the test
to terminate than we did previously. (Though the context cancellation
ought to also have killed all processes).
Release justification: roachtest change only
Release note: None