importccl: handle protected timestamp removal upon resume #45861
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
approved these changes
Mar 9, 2020
There was a problem hiding this comment.
Thanks. I don't think we'd crash but we would fail to mark the job as successful.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
If a protected timestamp is removed and the import job is resumed, we should still be able to mark the job as successfully complete. Release note: None
pbardea
force-pushed
the
import-protected-ts-err
branch
from
28313a0 to
d4c48f2
Compare
|
Flaked a few times on TestParallel/subquery_retry_multinode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a protected timestamp is removed and the import job is resumed, we
should still be able to mark the job as successfully complete.
Release note: None