Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add a comment that JSON behaviour is similar to JSONB #45831

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

giorgosp
Copy link
Contributor

@giorgosp giorgosp commented Mar 7, 2020

Closes #44465
Release note : None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@giorgosp giorgosp force-pushed the json-jsonb branch 2 times, most recently from b0113b9 to a09f57c Compare March 16, 2020 10:21
Closes cockroachdb#44465

Release justification: Comments only

Release note: none
@giorgosp
Copy link
Contributor Author

Sorry just noticed the CI failure. Fixed!

@giorgosp giorgosp requested a review from jordanlewis March 24, 2020 20:50
@tbg
Copy link
Member

tbg commented Jul 6, 2020

@jordanlewis did this slip?

@jordanlewis
Copy link
Member

Sure did! Sorry @giorgosp and thanks

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 6, 2020

Build succeeded

@craig craig bot merged commit 0b6e118 into cockroachdb:master Jul 6, 2020
@giorgosp
Copy link
Contributor Author

giorgosp commented Jul 7, 2020

No problem!

@SWDevAngel
Copy link

@giorgosp Hi George. Thank you for contributing to CockroachDB this year. As a token of our appreciation we would like to send you a gift. Please DM me on our community Slack @lisa so I can send you a link. (If you don’t want a gift, we also have a charitable contribution choice.) All orders need to be in by December 13, so please send this asap. :)

@giorgosp giorgosp deleted the json-jsonb branch December 8, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_json() results don't match Postgres
5 participants