sql,docgen: enable doc gen for SHOW SAVEPOINT STATUS #45794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SHOW SAVEPOINT STATUS statement is getting documented, so there's no point in excluding it from the syntax diagrams. Release note: None
|
This change is |
rmloveland
approved these changes
Mar 6, 2020
|
bors r=rmloveland |
Merge conflict (retrying...) |
|
bors r- |
Canceled |
rmloveland
added a commit
to rmloveland/cockroach
that referenced
this pull request
Mar 13, 2020
This change updates the syntax diagram definitions and generated BNF for several SAVEPOINT-related statements, specifically: - Add the SHOW SAVEPOINT STATUS statement to the list of syntax diagrams generated by pkg/cmd/docgen - Add the SHOW SAVEPOINT STATUS BNF file to the other generated BNF files - Update ROLLBACK TO SAVEPOINT to note that the savepoint name does not have to be 'cockroach_restart' It uses the changes in cockroachdb#45794, which enabled docgen for SHOW SAVEPOINT STATUS. It is part of the work surrounding cockroachdb#45566, which added preliminary SQL savepoints support. Release justification: low-risk update to documentation diagrams Release note: None
craig bot
pushed a commit
that referenced
this pull request
Mar 16, 2020
45962: sql: re-add GC job on schema element deletion r=pbardea a=pbardea This commit creates GC jobs upon the deletion of an index, table or database. Similarly to the previous implementation, it considers the walltime at which the schema change completed to be the drop time of the schema element. Release note (sql change): Previously, after deleting an index, table, or database the relevant schema change job would change its running status to waiting for GC TTL. The schema change and the GC process are now decoupled into 2 jobs. Release justification: This is a follow up to the migration of turning schema changes into actual jobs. This commit re-adds the ability to properly GC indexes and tables. 46048: docgen: update savepoint-related definitions, bnfs r=rmloveland a=rmloveland This change updates the syntax diagram definitions and generated BNF for several SAVEPOINT-related statements, specifically: - Add the SHOW SAVEPOINT STATUS statement to the list of syntax diagrams generated by pkg/cmd/docgen - Add the SHOW SAVEPOINT STATUS BNF file to the other generated BNF files - Update ROLLBACK TO SAVEPOINT to note that the savepoint name does not have to be 'cockroach_restart' It uses the changes in #45794, which enabled docgen for SHOW SAVEPOINT STATUS. It is part of the work surrounding #45566, which added preliminary SQL savepoints support. Release justification: low-risk update to documentation diagrams Release note: None Co-authored-by: Paul Bardea <[email protected]> Co-authored-by: Rich Loveland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SHOW SAVEPOINT STATUS statement is getting documented, so there's
no point in excluding it from the syntax diagrams.
Release note: None