Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: add support for gzip compression #45326

Merged
merged 2 commits into from
Feb 24, 2020

Conversation

dt
Copy link
Member

@dt dt commented Feb 24, 2020

This adds support for requesting data files written to cloud storage sinks
be compressed using gzip.

Fixes #43103.

Release note (enterprise change): CDC to cloud-storage sinks now supports optional gzip compression.

@dt dt requested a review from ajwerner February 24, 2020 16:31
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dt dt changed the title changefeedccl: add gzip support for gzip compression changefeedccl: add support for gzip compression Feb 24, 2020
@dt dt force-pushed the compress-cdc branch 2 times, most recently from 014d9dc to a0d0751 Compare February 24, 2020 16:36
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks for picking this up!

Reviewed 5 of 5 files at r1, 3 of 3 files at r2, 1 of 1 files at r3.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

dt added 2 commits February 24, 2020 18:06
This adds support for requesting data files written to cloud storage sinks
be compressed using gzip.

Release note (enterprise change): CDC to cloud-storage sinks now supports optional gzip compression.
@dt
Copy link
Member Author

dt commented Feb 24, 2020

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 24, 2020

Build succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdc: compress ndjson files for cloud sink
3 participants