release-19.2: kv: disallow parallel commit of batch with read-only requests #44703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
danhhz
approved these changes
Feb 4, 2020
nvanbenschoten
added a commit
to nvanbenschoten/cockroach
that referenced
this pull request
Feb 4, 2020
This was missed in cockroachdb#44608. I noticed while backporting that change in cockroachdb#44703.
Fixes cockroachdb#44315. This commit fixes an issue where KV batches with read-only requests were allowed to be issued as parallel commits. This should not have been allowed because the outcome of these read-only requests, notably Get and Scan requests, is not taken into consideration by the status resolution process for STAGING transactions. This would have caused serious atomicity issues if parallel commit batches (non-1PC committing batches) were issued with read-only requests by users of the KV API. Luckily, in practice that wouldn't actually happen as we never issue batches like that so there's no concern about production clusters hitting this bug. Still, this is a very good catch as this was a serious footgun and fixing this hardens the KV API. We should also still backport this to v19.2 just to be safe. Release note: None
nvanbenschoten
force-pushed
the
backport19.2-44608
branch
from
4315b45 to
ede3096
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #44608.
/cc @cockroachdb/release
Fixes #44315.
This commit fixes an issue where KV batches with read-only requests were allowed
to be issued as parallel commits. This should not have been allowed because the
outcome of these read-only requests, notably Get and Scan requests, is not taken
into consideration by the status resolution process for STAGING transactions.
This would have caused serious atomicity issues if parallel commit batches
(non-1PC committing batches) were issued with read-only requests by users of the
KV API. Luckily, in practice that wouldn't actually happen as we never issue
batches like that so there's no concern about production clusters hitting this
bug. Still, this is a very good catch as this was a serious footgun and fixing
this hardens the KV API. We should also still backport this to v19.2 just to be
safe.
Release note: None