release-19.2: sql: handle missing job when during mutations GC #44698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases where the schema changer tries to clean out the mutations on a descriptor. When it cannot find the job it currently throws an error and this does not let the transaction that cleans the job from the descriptor commit. However, if it cannot find the job then there is no chance it will find the job later. Currently, the schema changer will repeatedly attempt to clean this job and always fail since it cannot find the job. It should consider the job as successful if it cannot find the job and continue committing the transaction that does the cleanup for this mutation. Release note (bug fix): Stop repeatedly looking for non-existing jobs, which may cause high memory usage, when cleaning up schema changes.
|
This change is |
thoszhang
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Feb 4, 2020
44698: release-19.2: sql: handle missing job when during mutations GC r=pbardea a=pbardea Backport 1/1 commits from #44607. /cc @cockroachdb/release --- There are cases where the schema changer tries to clean out the mutations on a descriptor. When it cannot find the job it currently throws an error and this does not let the transaction that cleans the job from the descriptor commit. However, if it cannot find the job then there is no chance it will find the job later. Currently, the schema changer will repeatedly attempt to clean this job and always fail since it cannot find the job. It should consider the job as successful if it cannot find the job and continue committing the transaction that does the cleanup for this mutation. Release note (bug fix): Stop repeatedly looking for non-existing jobs, which may cause high memory usage, when cleaning up schema changes. Co-authored-by: Paul Bardea <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #44607.
/cc @cockroachdb/release
There are cases where the schema changer tries to clean out the
mutations on a descriptor. When it cannot find the job it currently
throws an error and this does not let the transaction that cleans the
job from the descriptor commit. However, if it cannot find the job then
there is no chance it will find the job later. Currently, the schema
changer will repeatedly attempt to clean this job and always fail since
it cannot find the job.
It should consider the job as successful if it cannot find the job and
continue committing the transaction that does the cleanup for this
mutation.
Release note (bug fix): Stop repeatedly looking for non-existing jobs,
which may cause high memory usage, when cleaning up schema changes.