sql: move the existing savepoint logic to a separate file #44684
+261
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
20200204-sql-savepoint-separate
branch
from
427948c to
6902fe1
Compare
yuzefovich
approved these changes
Feb 5, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andreimatei and @knz)
pkg/sql/conn_executor_exec.go, line 568 at r1 (raw file):
// commitSQLTransaction executes a commit after the execution of a stmt, // which can be any statement when executing a statement with an implicit // transaction, or a COMMIT statement when using
[nit]: could combine these two short lines.
pkg/sql/conn_executor_savepoints.go, line 79 at r1 (raw file):
// execRollbackToSavepointInOpenState runs a ROLLBACK TO SAVEPOINT // statmeent inside an open txn.
s/statmeent/statement/g.
This commit re-organizes the code without any functional change. Release note: None
knz
force-pushed
the
20200204-sql-savepoint-separate
branch
from
6902fe1 to
afc823e
Compare
knz
commented
Feb 5, 2020
There was a problem hiding this comment.
TFYR!
bors r=yuzefovich
Reviewable status:
pkg/sql/conn_executor_exec.go, line 568 at r1 (raw file):
Previously, yuzefovich wrote…
[nit]: could combine these two short lines.
Done.
pkg/sql/conn_executor_savepoints.go, line 79 at r1 (raw file):
Previously, yuzefovich wrote…
s/statmeent/statement/g.
Done.
craig bot
pushed a commit
that referenced
this pull request
Feb 5, 2020
43828: backupccl: add full cluster restore r=pbardea a=pbardea This commit adds the ability to entirely restore a full cluster backup. This includes replacing the contents of some system tables to match the data in the backup. Full cluster restore can be used using the `RESTORE FROM ...` syntax and is expected to be run on a new cluster with no user data. Release note (enterprise change): Add full cluster restore feature which restores all the information contained in a full cluster backup. This includes all of the user data as well as relevant data from system tables. It is expected to be run on a new cluster with no user data. 44684: sql: move the existing savepoint logic to a separate file r=yuzefovich a=knz This commit re-organizes the code without any functional change. (Split from #43051 for ease of review.) Co-authored-by: Paul Bardea <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit re-organizes the code without any functional change.
(Split from #43051 for ease of review.)