release-19.1: stats: fix flaky test TestDefaultColumns #44664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestDefaultColumns creates statistics on a table with 110 columns using the command `CREATE STATISTICS s FROM t.a`. It then checks that there are exactly 101 column statistics on table t.a with statistics_name = 's' (one stat for the primary index, plus 100 other column stats). However, this test may be flaky if automatic statistics are running, since each new automatic stat will cause other stats to be deleted. This commit fixes the problem by disabling automatic stats for this test, ensuring that the 101 column stats are not deleted after they have been created. Fixes cockroachdb#44208 Release note: None
|
This change is |
RaduBerinde
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #44560.
/cc @cockroachdb/release
TestDefaultColumnscreates statistics on a table with 110 columnsusing the command
CREATE STATISTICS s FROM t.a. It then checksthat there are exactly 101 column statistics on table
t.awithstatistics_name = 's' (one stat for the primary index, plus 100
other column stats). However, this test may be flaky if automatic
statistics are running, since each new automatic stat will cause
other stats to be deleted.
This commit fixes the problem by disabling automatic stats for this
test, ensuring that the 101 column stats are not deleted after they
have been created.
Fixes #44208
Release note: None