colexec: refactor CASE operator #44104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
force-pushed
the
vec-refactor-case
branch
3 times, most recently
from
0f93269 to
539a3ac
Compare
This commit removes selectionBatch which was used by the CASE operator and, instead, moves the logic that selectionBatch was providing into the operator itself. I think it is clearer this way. Release note: None
yuzefovich
force-pushed
the
vec-refactor-case
branch
from
539a3ac to
61606f4
Compare
asubiotto
approved these changes
Jan 21, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
TFTR! bors r+ |
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Jan 21, 2020
44104: colexec: refactor CASE operator r=yuzefovich a=yuzefovich This commit removes selectionBatch which was used by the CASE operator and, instead, moves the logic that selectionBatch was providing into the operator itself. I think it is clearer this way. Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes selectionBatch which was used by the CASE operator
and, instead, moves the logic that selectionBatch was providing into the
operator itself. I think it is clearer this way.
Release note: None