release-19.2: cli, sql: allow usernames to start with digits #42989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previousy, client usernames could only be valid identifiers, with the first character allowed being either a letter of underscore. This was an arbitrary limitation; in fact, production systems where usernames are just numbers (all digits) are common. This patch changes the limitation to allow CockroachDB usernames to start with digits. Release note (general change): Client usernames can now be defined to start with a digit; in particular, all-digit usernames are now permitted.
|
This change is |
|
Hey @rolandcrosby, I'm sure you're already aware, but we discussed in SIG today that this needs to get into 19.2.2 which means it needs to merge today or tomorrow. |
knz
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #42464 to unblock Active Directory testing.
Previousy, client usernames could only be valid identifiers, with the
first character allowed being either a letter of underscore.
This was an arbitrary limitation; in fact, production systems
where usernames are just numbers (all digits) are common.
This patch changes the limitation to allow CockroachDB usernames to
start with digits.
Release note (general change): Client usernames can now be defined to
start with a digit; in particular, all-digit usernames are now
permitted.