colexec: check for unsupported output type of a builtin #42968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would always create a defaultBuiltinOperator with a converted physical output type from a builtin function. This could be coltypes.Unhandled, and only during runtime we would realize that we do not support the output type of the builtin. Now this is fixed. Release note: None
|
This change is |
rohany
approved these changes
Dec 4, 2019
|
TFTR! bors r+ |
Build failed |
|
Flake. bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 5, 2019
42968: colexec: check for unsupported output type of a builtin r=yuzefovich a=yuzefovich Previously, we would always create a defaultBuiltinOperator with a converted physical output type from a builtin function. This could be coltypes.Unhandled, and only during runtime we would realize that we do not support the output type of the builtin. Now this is fixed. Fixes: #42871. Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]>
Build succeeded |
This was referenced Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would always create a defaultBuiltinOperator with
a converted physical output type from a builtin function. This could be
coltypes.Unhandled, and only during runtime we would realize that we do
not support the output type of the builtin. Now this is fixed.
Fixes: #42871.
Release note: None