release-19.2: sql: fix parsing of 0000-01-01 as Time/TimeTZ #42918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
force-pushed
the
backport19.2-42762
branch
from
a06eba3 to
905cc9b
Compare
Since `lib/pq` outputs `time.Time` for time datums as 0000-01-01, we should be able to parse this in. However, `pgdate` library cannot do that - so we hack around it for now by replacing the year for these kinds of dates. Release note (bug fix): Previously, attempting to parse `0000-01-01 00:00` when involving `time` did not work as `pgdate` does not understand `0000` as a year. This PR will fix that behaviour.
otan
force-pushed
the
backport19.2-42762
branch
from
905cc9b to
c09280f
Compare
solongordon
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #42762.
/cc @cockroachdb/release
Resolves #42749
Since
lib/pqoutputstime.Timefor time datums as 0000-01-01, weshould be able to parse this in. However,
pgdatelibrary cannot dothat - so we hack around it for now by replacing the year for these
kinds of dates.
Release note (bug fix): Previously, attempting to parse
0000-01-01 00:00when involvingtimedid not work aspgdatedoes notunderstand
0000as a year. This PR will fix that behaviour.